Benjamin Klotz

Adding devise async causes order dependent spec failures

10

Adding devise-async to our user model leads to generation of wrong SQL when devise does an auto update on login for request specs. For more details see: https://github.com/rails/rails/issues/26038 http://stackoverflow.com/questions/38635739/request-spec-order-dependent-failure-wrong-sql-created-for-devise-user-update-o A...

Relates to https://github.com/hanami/controller/pull/377 Most likely can be closed as `hanami/model` will go through a major refactor or will be completely replaced by rom 6.0. Opened it for the sake of...

Let me know whether the error should have another name, I thought the name `ContainerAlreadyFinalizedError` is adequate as it can be reused in the future for any operation on a...

Relates to https://github.com/hanami/controller/pull/377

Readd session errors

3

Somewhat unhappy with the implementation, but this introduces some tests as well on which we can rely on to refactor this. Feel free to suggest improvements, maybe we could leverage...

Add read only flash & session on request object

2

Branched off from the work at https://github.com/hanami/controller/pull/379

Return only validated params

2

When trying out the hanami 2 application template and using the `params` class method in an action I faced the issue that non-whitelisted params were accessible through `req.params.to_h`. This is...

HTTP::Error Unknown MIME type: text/html

4

When API.ai does not respond with json calling `#parse` on a HTTP response raises an exception as no other Mime Type handler is registered yet. (HTTP implements json handler as...