taicchoumsft
taicchoumsft
@darrenj . even if we set `includeAllIntents` to `true`, and even if we solved the lu de-dupe problem in Composer#7404, the disambig template will not work with LUIS. The new...
The original trigger design was to disambiguate between the top results of LUIS and QnA in the same dialog. It has absolutely no effect if only one recognizer is being...
We have two major options here: 1) **High Cost, High Risk (but right thing to do given current design)**: Copy `OrchestratorRecognizer`'s [disambiguation logic](https://github.com/microsoft/botbuilder-dotnet/blob/395c8bd1365dc042600ac8fe8546afc6f6eafaf4/libraries/Microsoft.Bot.Builder.AI.Orchestrator/OrchestratorRecognizer.cs#L192) to `LuisRecognizer`. This is done at SDK...
2) turns out to not be straight-forward. After some exploration for path 2, these are the findings: - enable `includeAllIntents` from the `recognizers/.en-us.lu.dialog` file: ```json { "$kind": "Microsoft.LuisRecognizer", "id": "LUIS_DisambiguationForLuisBot",...
@mrivera-ms , assigning these to you for now, as they are showing up in DRI report now that Ashley's left.
Thanks @Stevenic , attaching that issue you're [referencing](https://github.com/microsoft/botbuilder-dotnet/issues/5593) here for others. I will first investigate to see if even after caching we are logging twice. If not, then the suggestion...
Verified that we are still logging telemetry twice per turn in 4.14.1, we will fix this for next release.
The required check Breaking Change(Cross-Version) is failing due to changes that are not related to this new API version (see [details](https://github.com/Azure/azure-rest-api-specs/pull/27564/checks?check_run_id=23128861559)). Given that the https://github.com/Azure/azure-rest-api-specs/pull/21659 also had [the same detected...
@DominikMe , @johanste , the changes have been approved by the API review board, and the current build check breaks are not caused by this change, see [this comment](https://github.com/Azure/azure-rest-api-specs/pull/27564#issuecomment-2021643115). Awaiting...
@DominikMe , @johanste , can we request for a review on this PR? Is there anything we need to do to move this along? Thanks in advance!