Tahmid
Tahmid
it fixed the sample code in the issue and in my larger codebase
I don't really know what a new test should do originally, the debounce test gave a false positive, now it's a true positive, but the test itself already covered the...
this fix will now cause an error if only two biomes is registered (ceil(log_2(2))) = 1 via uses the bit number for the global palette as the ceil(log_2(number of biomes...
https://github.com/ViaVersion/ViaBackwards/blob/master/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_17_1to1_18/packets/BlockItemPackets1_18.java#L177 https://github.com/ViaVersion/ViaVersion/blob/master/api/src/main/java/com/viaversion/viaversion/api/type/types/version/PaletteType1_18.java#L44 I'm not quite sure of a good way to fix it really
PaletteImpl#fixBitsPerEntry(int) appears to have a hardcoded value when in reality it should be the ceilLog2 of the numbers in the "global palette" I believe 15 is fine for block states,...
fixed by another pr
from what I can see, there is also a lastSeparatorIfSerial method which is mutually exclusive, in terms of functionality, with lastSeparator should I add something like ? or ? in...
I added an argument for lastSeparatorIfSerial. I'm not sure if TagResolvers are the best approach here. Personally, I think I think that using Components would be more convenient. If I...
any love? :slightly_smiling_face:
I think I could try that. but does it not make more sense to have it automatically read early data when you read from the stream? for parity with when...