Philippe

Results 19 comments of Philippe

By setting `"generateOptionalPropertiesAsNullable": true` (instead of `false` before) the property becomes nullable (that's good). But I've noticed ALL properties which are not `Newtonsoft.Json.Required.Always` are marked with `Newtonsoft.Json.Required.DisallowNull` whereas I'd expect...

I've encountered this issue again when integrating a new API. The fix I've applied is pretty simple: Replace `Required = Newtonsoft.Json.Required.Always` with `Required = Newtonsoft.Json.Required.Default` but it is a pain...

@ewoutkramer To cover my use cases, the interface implementation (covering only the `Identifier` property) would be sufficient ```c# public interface IIdentifiable { List Identifier { get; set; } } ```

@Wangor No update I'm aware of unfortunately

Hi, I wanted to ask if you're still considering adding this? (as mentioned in the initial post I'm wondering if you couldn't use the same concept to provide an `IIdentifiable`...

@ewoutkramer you mean creating a partial class like this https://github.com/taconaut/firely-net-sdk/pull/1 for the 111 classes having this property in R4?

Yeah, most but not all of the models have this property. 111 in R4 and 141 in R5. Having to do this manually would be tedious and lead to a...

FYI I've started working on a postprocessor, which will have to be ran after the generation of the FHIR models, before the models are being committed to the GIT repo....

I've stayed with the post processor approach for different reasons. Hope it fits

Hi @ewoutkramer, did you have the opportunity to have a look at the PR? Running it, as it is meant to be ran during the generation process, is as simple...