Cristian Tăbăcitu

Results 540 comments of Cristian Tăbăcitu

The lines have changed since then. I just upgraded and had to redo this: look for the functions getState() and _get_delete_url() and change wherever you see $rsegments_array[x]. For example: site_url('admin/'.$rsegments_array[1].'/'.$rsegments_array[2].'/delete_file/'.$value);

> Just i have one little comment for @pxpm and @tabacitu i try to replicate this problem check rows from first page and combine with last page, but the bulk...

Note - discovered in https://github.com/Laravel-Backpack/CRUD/pull/4558#issuecomment-1205925548

Changing from localstorage to server session sounds like a change with unforeseen impact. People might have done customizations on top of our localstorage implementation, so changing it might break their...

😅 I need @jorgetwgroup 's approval to merge, @pxpm . If he's the reviewer, best to leave him final say on this, he's the one that should say "_Tabacitu, merge...

Thanks @ziming - we're currently deep into improving the onboarding, but we'll take a look shortly. Cheers!

Thanks for opening this, and providing the solution @shivammathur . But it sounds like a bug... if it's a bug, we should take a look and fix it too.

We decided to write docs for this in this PR, then try doing MorphToMany too, see how the docs would be different between the two.

I like this! Thanks for submitting the PR @iMokhles , I've tagged this so we take a look at it when we release 4.2, maybe we include it there 🥳

Note to self: we also talked about adding a `wrapper[separator]` attribute. Details in https://github.com/Laravel-Backpack/CRUD/pull/3435#issuecomment-769476582