takaaki shimbo
takaaki shimbo
@ikhoon There might be some not-good parts, but I'd like to check if this implementation corresponds to your thinking of the implementation. Could you please check?
@ikhoon @trustin @minwoox @jrhee17 Iām sorry I have kept you waiting šāāļø I addressed your comments. Could you please review it again?
Thanks for your polite explanation. š It makes sense to me. I'll work on the new API design.
@minwoox @ikhoon Some features have not been implemented yet. However, I have some questions and want to check if we are on the same page. Could you check if the...
Sorry for the late reply. > LoggingDecorators is no longer used if we introduce LogFormatter. Isn't it? I'm not sure about this. It seems to me that LoggingDecorators has more...
Thanks for your support. It seems good. I'll work on it
I think the above distribution summary can be applied by setting as the following What do you think? @okue ```yaml management: metrics: distribution: percentiles: armeria.server: 0.5, 0.75, 0.9, 0.95, 0.99...
May I work on this issue?
@ikhoon How about setting `DefaultRequestLog` as the argument of `LogFormat#format` to handle flags, etc.? ```java interface LogFormat { String format(DefaultRequestLog log, LogSanitizers sanitizers); } ``` In the current implementation, the...
Should we need to check the value of `flags` in `DefaultRequestLog`? https://github.com/line/armeria/blob/e08b6eabcf9f8ddf231b8744026dd5dbd6342271/core/src/main/java/com/linecorp/armeria/common/logging/DefaultRequestLog.java#L230-L232