t92549

Results 48 comments of t92549

As explained, https://github.com/gchq/Gaffer/pull/2704 added an Operation called ToOpenCypherCsv. This isn't a very extensible design for adding new Csv formats though, so instead ToCsv should be refactored. Ideally, it should keep...

The temporary fix in the HasTraitHandler looks like this: https://github.com/gchq/Gaffer/blob/40bb337d2ca91fea2dadcd04cddec46021c169ee/core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandler.java#L35-L44 This needs a better long term solution. This potential bug (where the flag wasn't checked) was caught by @GCHQDev404 in...

@n3101 I think this is still relevant. This kind of relates to a whole load of ideas described in https://github.com/gchq/Gaffer/issues/1833. Ideas which I have been toying with recently and I...

Alternatively we could look into [codacy](https://github.com/marketplace/codacy)

Each Accumulo Range could be [bound](https://accumulo.apache.org/1.9/apidocs/org/apache/accumulo/core/data/Range.html#bound-org.apache.accumulo.core.data.Column-org.apache.accumulo.core.data.Column-) by the groups.

After some local testing, this feature is possible but would require a decent amount of refactoring of the Accumulo key packages, and would fundamentally change how Gaffer filtering is done....

It would also be nice to test everything against both Java 11 and Java 8.

For reference: https://github.com/gchq/Gaffer/blob/23c323e894c8dba3e25029c3699b6fb5a050a39e/store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java#L612-L638

@GCHQDeveloper314 That would remove the direct Accumulo library usage, but there is still Accumulo store specific code. I think a more generic fix could be to implement a rename graph...

The fix for this has to be smarter than just checking if the FederatedStore is assignable from the store in question, because it can also be valid for ProxyStores pointing...