Jacky Jiang

Results 66 comments of Jacky Jiang

@srenatus Thanks a lot for your reply 👍 I am actually having some performance issues here. And my concerns probably cover both. i.e.: the compile result should - neither include...

@srenatus Thanks so much for looking into it. Also appreciated the `opa eval -fsource -p` tips --- it's much easier to look into the compile result 👍 We actually use...

@srenatus Thanks a lot for looking into it. I can confirm that I also got signification improvement on our latest policy files --- down from 284 to 112 rules (**i.e....

Comment from @na9da for his investigation result & possible options: So, I took a closer look at this issue for fixing TS4094 https://github.com/TerriaJS/terriajs/issues/5866 . The error basically says TS cannot...

I think we probably can have a try the "Declare the return type explicitly" approach (might similar to the option 3 @na9da suggesting ). i.e.: ```typescript export function test ():...

Sample code for two solutions (option 3 & 4) from @na9da ```typescript export type Constructor = new (...args: any[]) => T; ​ class BaseModel { baseMethod() { return "baseMethod"; }...

had a chat with @na9da so to make it clear: - the only solution that we have & work is option 4 above. - but it increases the complexity of...

Here is a playground example of option 4: [Playground Link](https://www.typescriptlang.org/play?ssl=63&ssc=28&pln=63&pc=78#code/KYDwDg9gTgLgBDAnmYcDCEB2BnGUCuAxjNADwAqAfHALxybADucAFAHQcCGUA5tgFxxOmRAG0AugEpa1cgG4AUIGgCBYQA2nbNjgAhTcACyEACbA1cAN4K4cAEb6DwGAAsTLaVZs2oT-FExwAET22IZOrsaBijYAvgpxKqbq3KictrhQnMRwyVpwAMoAlgC2YGqGhSCFmOTApRowqJ5C6XhZ8PYAXu6CGdU80XDYJWXAPUN4-YoJCqCQsHAAZviYxIVYBSPlBpXVFHCgjZjG2hg4eEQkUKR6oUamapSULNa6+oLkCpIfcABk6FgMpcyEV6hUqjU6mVOI1qM00hl2jkNHlQaMdhCDiAjic3qFLK8bAi2tkuuM+pgBoS4GAoIUAG4w1C0hlM-IwJm0IIsxmNdlMqLUnmc4WNRwuNweaneXz+BDOQrYNii4D8xqDWLKanDMHuAleLw+GB+AIuRXKum8sIS4zuDVwOKalQ2AD0LrgAHkwDB1gEAMyCAByEBymh9lLgPgAjvhCj5jDZnMAfHBGEmApgIPB8MMIwADWlZ4DEYDGPNwYp1WzJpU2fIh8j5VOFNRqV5uyPAebwZNQaDaQqLOAQPybMEY6pwLZ1YCYDk+jbGQeLGtLPvFeXAdvuzjGenJn2hBPVRpQRZZVCTtHbXaQ+pMtivI0msfo29CbTCRDTLW5bS1XBr1QQ5Z1xICJ0wFhbkMEwzClGwyXgw1ZQCYJOE6QVNRmZZVgXU1gEA6c9WaQhAXgRpcC5BhmAAmAgLtV5SJwCByjYNQIB4FgKJgNgdVGdwABoEAInjEKE7i2BCa0IncSQf0SYsNBTYlMmyP84AABT7RoS2MCDanvRp9RpbTi0aBMVKRewoHJSZKUGRYIAgWy6Xs+ItTmaB4BwtYNi0otdIg-YQOOU4yIIYgyGg+4zCeF4bGgj4vh+f4ziBSLrn8nTzP0qEGmAOFXkstSUW0LKzNLCCsRxbRoOMmxC2y0sWkRUluBcqZqUc5ykINZ85TNJVrIYg1HQdLVXXdL08LgAAWQQAHVUAYZqSCWaBCFQFxUEIMM2AKBsm0YLAAHJyOcPtmC-A4oD7KAByHbaK3fadKznGFfW3OBTHpQomW0RZ103IQ9wPRVmpPZNz02qcAnKwLbwM6FGkfGVjTleGcvfTQ4BWABrTNGACHHyD+AFzgiq5SExyrEbyplKHk1RSrgWiaYTELcXZiCoIcWC1CQ4bes7dHUOszDxuwlZfPw3B2eIxiyOEyi6Go1mRPluTFeY1j2M4iTusE5XRIccJJS1qXcN9Y2FZsbj6K1u2NdM3SGJmbi7SAA)

There is also a symbol-based property hiding solution I think might help with an easier solution under certain circumstances : https://github.com/microsoft/TypeScript/issues/17744#issuecomment-431534647 @na9da suggested could be a supplementary solution to option...