Konstantin Tennhard comments

Results 6 comments of


                                            Konstantin Tennhard

Installation Instruction

I'm happy to do that once I figured out how to install the files. Where do you put the files in the `src/` directory on Windows so that the Native...

Add a skip state to skip processes when they don't apply to the pipeline

It certainly wouldn't hurt, but I would call the method `succeed` so it resembles the name of the state. If you open up a PR, I'll merge it.

Explicitly passing nil default property fails required check

This is indeed specified behaviour: https://github.com/t6d/smart_properties/blob/master/spec/required_values_spec.rb. That said, I'm currently working towards a `2.0` release and will investigate whether making the behaviour configurable is an option.

Use the index methods as central mechanism for reading and writing properties

@exterm, does this in essence capture what needs to be done? @SebastianSzturo, any concerns in regard to fundamentally changing the internal flow of information? I expect we can do this...

Support validation before and after conversion

There is no harm in adding a `prepares` hook, so that the execution order would be `prepares -> converts -> accepts`. I'll actually try and release this as a feature...

Support validation before and after conversion

By the way, I can highly recommend using dedicated objects for complex validation and conversion operations: [SmartProperties advanced input validation](http://t6d.de/presentations/smart-properties/#6).