Sylvain
Sylvain
## Review checklist for @sybreton ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
Hi @dfm, Before we go on, can you formally confirm that the COIs I might have with @darthoctopus have been waived ? We have been co-authors on the following large...
Thanks for the information ! I went to check the co-author list in order to check possible COI, I hope everything should be fine: Martin Nielsen is also among the...
@dfm Perfect, thanks a lot for the check, I will proceed with the review !
@dfm - Sorry I have been wanting to answer you for a few day already ! No particular issues to mention on my side, once @darthoctopus will have added the...
On my side I validated all the items of the checklist and I am also completely satisfied with the additions that have been made!
Well I have not specified it explicitly in the issue description above, but the problem is that ``quantiles`` is not an argument that requires mandatorily 3 elements as ``title_quantiles``, here...
The main problem is backward compatibility: any code that ran smoothly before v2.2.2 now breaks, even if the `quantiles` value it provides is still valid from what can be read...
I totally agree with the point raised by @ShaiAvr. @wmwolf, about your concern related to importation I do not see this as a particular issue in this case as `pathlib`...
Perfect, thanks a lot !