Yan, Shaopu
Yan, Shaopu
hi [cpanato](https://github.com/cpanato), [bobcallaway](https://github.com/bobcallaway), would you help to review this PR, which is to provide another alternative cloud KMS eHSM-KMS. eHSM-KMS is An End-to-End Distributed and Scalable Cloud KMS built on...
> sorry for the delay, I will need a bit more time to review and have others to review as well > > cc @haydentherapper Thanks. Any comments for this...
> Hi @syan10 > > First off sorry for the late reply and thank you for your contribution. > > A few considerations that come to mind (correct me if...
Thanks for pointing the issues. for the 2nd one, we will take a look and fix it soon. (also welcome for your contribution if you want to..) for the 1st...
> > for the 1st one, could you provide more details, since i'm not quite understand your point. Because it will return error directly when it hits the below condition:...
Yes, it's a common issue now. A quick fix is to add a check at the beginning of the original checks, to make sure the size is larger than the...
Thanks for your contribution.