sya-ri

Results 7 comments of sya-ri

It would be even better if this was supported by the ModelFile API. I'm imagining code like the following: ```java // File file ModelFile modelFile = ModelFile.load(file); // File imageFile...

> Again, this should not be a replacement. This should rather be an alternative for those who want this. Does that mean I should leave the method's arguments and processing...

@DerEchtePilz Thank you for your interest. We will need to make a breaking change to "optional". Currently, specifying `optional = true` for argument makes it **nullable**, and specifying false makes...

> We obviously settled on the second option and the reason was that doesn't require twice as many methods. Yes, that's exactly right 😢 https://github.com/JorelAli/CommandAPI/blob/3dafcf8ab2a0bf5b407930cf12f67ea4b3ade0c6/commandapi-kotlin/commandapi-bukkit-kotlin/src/main/kotlin/dev/jorel/commandapi/kotlindsl/CommandAPICommandDSL.kt#L114-L117 https://github.com/JorelAli/CommandAPI/blob/3dafcf8ab2a0bf5b407930cf12f67ea4b3ade0c6/commandapi-kotlin/commandapi-bukkit-kotlin/src/main/kotlin/dev/jorel/commandapi/kotlindsl/CommandTreeDSL.kt#L107-L110 https://github.com/JorelAli/CommandAPI/blob/3dafcf8ab2a0bf5b407930cf12f67ea4b3ade0c6/commandapi-kotlin/commandapi-bukkit-kotlin/src/main/kotlin/dev/jorel/commandapi/kotlindsl/CommandTreeDSL.kt#L212-L215 I would like...

> But yeah, those deprecations are already in the process of being removed, we just can't do it until 10.0.0 I see. Changes to this issue will also be merged...

OK. I will create a PR as soon as possible 😉

@amitguptagwl Thanks for your reply. I **mostly used the original benchmark code as is**. As for the `xml2js` part, I **did not modify** anything myself, but I tried uncommenting the...