Xiangyu Shi

Results 14 comments of Xiangyu Shi

Hi @nathanlesage, could you help us to review this pull request?

Hi @kyaso, could you help us to review this pull request?

> Overall, this looks promising! I have added some comments. Maybe @nathanlesage can also have a look when he has time again. > > One thing I noticed: When you...

Hi, I update my code based on the feedback from @kyaso. Also, I do not really understand the meaning of "Do not alter the language files." from @nathanlesage feedback. Does...

> @sxyxs This meant that you should not modify any of the language files. We have to do it via Zettlr Translate, i.e.: I need you to provide a list...

Hi @nathanlesage, the only thing we have changed is to add a new copy button in each code block introduced in the PR's introduction. ![Screenshot from 2022-06-09 21-03-49](https://user-images.githubusercontent.com/91049482/172837529-ed8db900-4d06-4144-908f-ca58efc85df9.png)

@kyaso Thanks for your feedback and sorry for missing one point. I have fixed that.

Hi @kyaso, I have already fixed what you want me to fix. Please check.

> @sxyxs It looks fine to me. I think there is one minor improvement left which you could implement: [#3501 (comment)](https://github.com/Zettlr/Zettlr/pull/3501#discussion_r884148472) > > @nathanlesage Would you mind having a final...

> @sxyxs Looks fine from my side. > > Would you mind rebasing your commits on top of the latest develop branch and also squash the temporary commits to clean...