Svante Bengtson comments

Results 37 comments of


                                            Svante Bengtson

Error when using "reference" type

Hi, not currently. There are some decisions that would have to be made to support this. Since the `DocumentReference` instance contains the full path to the document it references, not...

Reduce dependencies

I can see the appeal, but it would lose a lot in terms of maintainability for me. The point of depending on those packages for types is that I can...

I've released [v5.2.0](https://github.com/swantzter/apollo-datasource-firestore/releases/tag/v5.2.0) which removes the dependency on `apollo-server-errors` Yes, if the underlying datasource types change in a major way this library would need a major version, that's already happened...

Consider a way to handle sub-collections and their types

Right now there isn't a way. I haven't been able to think of a nice way to design it. Suggestions welcome. One option I've thought about is initialising it with...

use docRef.update() instead of docRef.set()

I could see the value in using `.update()` for partial updates, but when doing a full update I think `.set()` has a more expected behaviour since it removes any other...

Support displaying arbitrary time zone settings.

I'd like to +1 this as well, though I'm thinking maybe we should provide an `afterLoadData` snippet in the meantime. So, for everyone scratching their heads at this issue in...

sans-serif support

@mhchem bah, my editor automatically formated it according to standard js when I saved... Grep for `\\sf` in my fork, that's what I added

Don't show STATUSMSG as separate tab

This also has the addition that it's not just NOTICEs that can be sent as STATUSMSG. PRIVMSGs can too - which might be worth remembering

SASL+TOR+FREENODE How to

@christeld we should potentially look at making this mergeable?