Craig Cornelius

Results 11 comments of Craig Cornelius

There are a couple of things that should be done with this PR: a. The commit messages must include the issue information. Please see: http://site.icu-project.org/repository/gitdev#TOC-Review-commit-to-Unicode-master b. Please take a look...

Not sure where this could/should be merged.

We could add dead key support for the grave accent at E00, similar to the acute dead key transforms here. However, this layout has the _combining grave_ on E00, which...

I am unclear as to why we want to use the dead key method when the combining grave and combining acute are on E00 and D01 already, supporting vowel +...

Thanks for the notes on this PR. I've moved test files to the right directory and added test strings including region names, days, months, some geographic features, and a few...

Thank you for your help, Lorna. I will close this PR and then create a new one carambolfulbhe with the new keyboard. The new PR is here: https://github.com/keymanapp/keyboards/pull/3607

Thank you, Lorna, for your helpful comments and notes. I'm working on this PR to update it as suggested. David, I'm changing the language code as suggested.

Thanks for your patience. Please take another look.

Updated as suggested. Thank you!

Thanks, Lorna, for these updates. Anything else to do at this time?