Sveinn Thorarinsson
Sveinn Thorarinsson
> Thank you for submitting this PR. > > As things stand I'm unable to accept it. At a minimum, there needs to be a test case that proves the...
> Thank you for working on the changes. It seems you have missed out on a variable that affects some tests. I left few extra comments to keep the tests...
> Thanks for addressing the suggestions so quickly. We're nearly there. I left few more comments on the min and max checking as well as tests formatting. Sure thing. Just...