Suyog Rao comments

Results 14 comments of


                                            Suyog Rao

[Pub/Sub to Elasticsearch] Fix error handling

@Cherepushko can you rebase please? Also, can you add in the description and code comments we are removing invalid fields (with only dot as name) so Elasticsearch doesn't throw exception...

[Pub/Sub to Elasticsearch] Fix error handling

Also left a comment for adding unit test for the method that removes dots from k8s logs

[Pub/Sub to Elasticsearch] Fix error handling

LGTM

Updated README.md for BigQuery to Elasticsearch template

@prathapreddy123 @Cherepushko FYI

Kafka To Elasticsearch Template

@prathapreddy123 is it better to place this inside of google cloud to elasticsearch folder?

Kafka To Elasticsearch Template

@prathapreddy123 can we get a review please?

Route errors to pubsub

@prathapreddy123 any reason this is still open?

Updated README.md for GCS to Elasticsearch template

@prathapreddy123 @Cherepushko FYI

Implement Java Version of this Plugin's Logic and Benchmark against Current Version

Just as an FYI when we get to this. The original ruby (and C!) implementation from @jordansissel is here https://github.com/jordansissel/ruby-grok. We should port all the awesome tests from that library...