Addison Hanrattie

Results 26 comments of Addison Hanrattie

I have updated this PR to be compliant with the instructions provided. I also fixed the failed checks, it turned out I was accidentally calling a method that doesn't exist.

Latest push resolved new conflicts.

So I have multiple WLEDs across VLANS but I cannot forward broadcasts for separate reasons, thus what if I reformed the commit? My whole objective with this PR is to...

Yeah I'd agree that a user mod is a better way of implementing this since my current implementation would needlessly complicate the UX of the average user.

Sorry, there is interest I just haven't had time to work on this. I'll reopen if I find time however I will close it for now for your peace of...

I will add the docs part when I get a chance and then ready this for review other than that any thoughts on this implementation

Ok, this is ready for review now, I have added the docs.

I'm getting the following error now @ianrrees ``` = note: rust-lld: error: undefined symbol: _critical_section_1_0_acquire >>> referenced by lib.rs:193 (/Users/addisonhanrattie/.cargo/registry/src/index.crates.io-6f17d22bba15001f/critical-section-1.1.3/src/lib.rs:193) >>> /Users/addisonhanrattie/Documents/atsamd/boards/grand_central_m4/target/thumbv7em-none-eabihf/debug/examples/blinky_basic-66cbd02f4a7e08ab.blinky_basic.dd7903c5ecf9b979-cgu.0.rcgu.o:(critical_section::with::h392fdb763c500007) rust-lld: error: undefined symbol: _critical_section_1_0_release >>> referenced by...

@jbeaurivage @ianrrees thanks for the guidance on this

I won't have access to my leonardo for a few weeks and haven't been able to test these changes which is why I marked as draft. If someone can confirm...