sulai

Results 10 comments of sulai

I'm happy to see you are contributing to brogue! I'm currently not active in brogue community, but certainly will in some future. Happy coding! :)

> Right now, we have "wait" = "I want to move this unit next turn" Related: #12308

Thank you guys for looking into it. I moved the "Buy Button" logic from the CityConstructionTable to the ConstructionInfoTable, while the actual logic stayed pretty much the same. This part...

![Screenshot_20241020-132245](https://github.com/user-attachments/assets/0453378e-cdd3-433f-a95a-206c22587029) - The stats are collapsible. Sometimes that table takes too much horizontal space, for example when the WLTK text is shown or with certain religions. - the queue button...

Sounds good to me! I'll extract the button, let me know about the poll results. 👌

I created a BuyButtonFactory, because there is no actual Button class in the original code, but methods creating that button. I didn't see any other factories in the code base,...

Hey @yairm210 , thank you for putting up the poll, but I have a follow-up PR ready, which would favor the "buy" button to stay where it was. ![Screenshot_20241022-093718](https://github.com/user-attachments/assets/4889d31f-ba56-47cc-aaea-90e2cdf00bea) Regarding...

We just discussed this same topic here #12745. Our discussion was focused on how confusing the different buttons are to new players. Visually, these < and > buttons don't visually...

I see your point about the Wait button. The label might lead users to think the unit will be brought up later in the same turn. > Having an explicit...

Thank you for your positive reply. Allow me to add some details: If you switch windows fast, like in 1s interval, the gap can be larger (multiple 0-length events). When...