Wonsuk Choi comments

Results 8 comments of


                                            Wonsuk Choi

refactor(config/defineViteConfig): replace deprecated 'UserConfig' with 'ViteUserConfig'

@atomiks Could you review this PR?

refactor(react, react-dom, eslint): rename 'useModernLayoutEffect' to 'useClientLayoutEffect' for clearer semantics

@FezVrasta The previous name, `useModernLayoutEffect`, felt a bit abstract and may not have clearly conveyed the hook’s behavior. Since the hook only runs on the client and no-ops during SSR,...

refactor(react, react-dom, eslint): rename 'useModernLayoutEffect' to 'useClientLayoutEffect' for clearer semantics

@atomiks I appreciate the detailed explanation and historical context, especially that this hook exists to avoid warnings in React 17 and 18, and that the name `useModernLayoutEffect` was introduced to...

refactor(context): add React.FC type in Provider

@chaance in UI Tests, is there any problem?

refactor(site): unify components with export const arrow function, simplify structure in system and typography

> @sukvvon Any plans to address the feedback on this PR? If not, I will close it. @askoufis It might be better to close the PR for now. If a...

100% coverage

> [@sukvvon](https://github.com/sukvvon) If you have interested in suspensive contribution, could you do this please? @manudeli Thanks for your suggestion, i’m not sure how long it will take, but let’s try...

[Feature]: Please, adding the on and off feature of dark mode. 😊

@manudeli I think we can close this issue. ☺️ * #1755

test(solid-query/useQuery): migrate to fake timers with 'advanceTimersByTimeAsync', add 'expect().toBeInTheDocument()', convert sync 'queryFn' to 'sleep().then()', and add detailed timing comments

@TkDodo I converted complex `then` callbacks (with multiple statements like variable increments, conditionals, or throws) to async/await pattern, while keeping simple one-liner `then` callbacks (e.g., `sleep(10).then(() => 'data')`) as-is for...