Suket Sharma

Results 18 comments of Suket Sharma

Overloading a single arg to either be a file or actual content seems odd to me, and don't think we should go down the route.

> So you're thinking about a scenario where there is a custom AMI and the file has been already backed into it, I guess? I was actually thinking of using...

Hey Steve, apologies for not responding earlier. > This behaviour has always been wrong as there is the USE_MAX_PODS variable to disable using the values in /etc/eks/eni-max-pods.txt as the node...

Sorry, I hit enter too early on my previous post. We do intend to have better defaults but there's no concrete timeline I can give. It's unlikely that our defaults...

As a possible workaround, you could pass the API Server endpoint and the Cluster certificate data to the bootstrap script and avoid the EKS API calls

We were trying to solve a similar problem with Karpenter too and an alternative approach we've adopted [is introducing a different flag in the bootstrap script](https://github.com/awslabs/amazon-eks-ami/pull/905) that doesn't enable the...

Right yes. The script to run the kubelet is only - ``` systemctl enable kubelet systemctl start kubelet ``` and before you do that, you can merge in the json...

The alternative I've been thinking of is that the bootstrap script supports accepting two filePaths : one that points to the kubelet configuration, and one to the container runtime configuration....

> That said, I think you'll have to offer a switch between the new binary and old shell bootstrapping; so I don't think it matters if more work is done...

Playing devil's advocate, there's no way enforce backwards compatibility regardless :( If someone's using Managed Nodegroups and is editing the `/etc/eks/bootstrap.sh` file on disk directly in their MIME part, all...