sudden6
sudden6
@dvn0 please add at least one positive and possibly one negative test case to: https://github.com/qTox/qTox/blob/master/test/chatlog/textformatter_test.cpp
Can you please attach the following details: - qTox log output - number of screens attached - resolution of the screens
Hmm, the log doesn't show anything interesting. Can you test with a nightly build: https://github.com/qTox/qTox-nightly-releases/releases/tag/ci-master-latest?
Ok, that at least confirms the problem is still there in master. I just tested this on Linux and it doesn't seem to happen there. There seems to be no...
Good catch, fixed.
@bodwok can you re-review and give lgtm when you are satisfied?
@sphaerophoria I'm not yet deep into the changed code by @anthonybilinski but it seems that your proposed architecture additionally complicates the dependencies (diagram 3). AFAICT with the dispatcher you're mostly...
@sphaerophoria yes that is exactly my main concern. Another concern is that now instead of one slightly complicated class (CoreAV) you have two classes (CoreAV and the Dispatcher) that need...
> Without the split you have to instantiate CoreAV which I would imagine is not trivial to do easily in a testing context. I'd have imagined to use a mock...
> Thoughts? To me this seems a bit over engineered for what we use it now and I fear we'll never use the functionality of the extra manager class to...