Stuart Douglas

Results 80 comments of Stuart Douglas

I have no real familiarity with this code, so it really needs someone who knows it to look over this.

ClassLoader is not serializable, and it literally the field above what I have added into DeploymentOptions. If this is a problem though I can remove it, as we mainly need...

@pmlopes good point. I will need to think about how to handle that. Maybe Supplier is not the correct approach and we should have some way of notifying vert.x when...

I have updated this, to also allow for registering listeners that are notified on ClassLoader change.

Yes, although ideally this will apply everywhere so that the original CL does not leak.

What exactly is this used for? The correct solution will likely depend on the use case.

We can't log full stack traces for invalid tokens by default, it opens up an DOS vector where an attacker can send a massive amount of requests with expired tokens...

Trailers should be supported. Is there an easy way for me to test this so I can see what is wrong?