tomasz stryjewski
tomasz stryjewski
i'd go with a service wrapped around this particular modal that would return a promise :-)
I could possibly "fix" that
happy to help. I understand that the speed is the main priority, but I'd consider it a rather serious flaw - it should be at least documented :)
Another potential issue: since you're using instances as cache keys, you potentially keep the instances from being GC'd and hogging the memory - just something to think about :)
sure, but here's a twist: how will you serialize and compare the `arguments`?
You could create a special cache for a calls with `Object`s in arguments. This will be a serious perf hit... :/
I'd just handle the one argument scenario and document the complexity without implementing. current solution will work for **most** of the cases, so it should be good. However, it **needs...
on top of that, i'd switch the order of `prefixer` and `minifier`, just for the sake of keeping the order correct ;-)
found a way to differentiate the two events. quick demo: http://jsbin.com/ewadin/1/ would you care for a "fix" + pull request?
i'll try to take a look and fix the bb+requirejs anything else than lack of trimming the input value?