Simon Tooke
Simon Tooke
> * [x] Please consolidate the commits. E.g. combine subsequent style related commits into one (or even better, fold them into the commit that is the origin of the style...
@pejovica thank you for the extensive review! I'll be responding to the issues you've raised over the next few days.
@pejovica , thanks again for the review. I'm made extensive changes in line with your suggested improvements. Some conversations I left unresolved as I might have a question or two....
@pejovica, I've updated, but (like many other PRs) I can't pass the debugInfo gates because of issue #4018. Please let me know if there's anything I can address in the...
Hello @pejovica , and thanks for the review - I have incorporated the changes suggested into the prereq PR #4333, and will update this PR shortly.
@pejovica , I have updated this PR to reflect the changes from the prereq PR. While doing so, I've simplified CVTypeSectionImpl, and refactored CVTypeSectionBuilder to separate out utility functions (getIndexForPointerorPrimitive()...
@pejovica , thanks for this review cycle, and especially the catch of the reversal of typeindex and vtable in one of the type records. As far as I know, I...
> Ok so it seems most gates are passing except for unfortunately some that build the EE version of `gu.exe`: > > ``` > Fatal error: java.lang.RuntimeException: There was an...
> > If I can get hold of the object file, I might be able to see what's out of place. > > Sounds good. Maybe we can provide that....
Looking at the code in my repo (which needs a rebase so is slightly our of date), in SubstrateCallingConventionKind.java, there are only three calling conventions - Java (needed), Native (generated...