stoneharry
stoneharry
@robpaveza Any chance we can get this and #1 merged? :) I guess I can fork this repository and merge the two pull requests into my fork, but it would...
Your fixes provided all the functionality I wanted, @HelloKitty 😄 I cannot think of another reason to extend it right now. I'm only using this library as I'm working with...
I love the motivation behind this PR. The inconsistent naming is something I have moaned about for a long time, so good on you for taking this work on. However...
> @stoneharry a couple of notes unrelated to the pr: columns are case insensitive in mysql, and joins with tables should always use aliases, like JOIN creature_equip_template AS cet ```sql...
My point was if we are standardising the column names, we should be using id not CreatureID. What you call your tables when joining is irrelevant.
Maybe a simpler example is: ```sql SELECT * FROM creature_template WHERE CreatureID = 10 ``` We already know we are targeting the creature_template table, it should just be ID. If...
> CreatureID in creature_template table as PK is just wrong, PKs should not have the table name in them. Which is what I wrote in my example above that I...