Stokhos

Results 16 comments of Stokhos

I found this line of code in `normal_mode.rs`. https://github.com/kneasle/sapling/blob/1c57e649bce8539b224e79e93d7464784148facd/src/editor/normal_mode.rs#L33 Are we overload the `self` with our own pointer here? But the `self: Box` is immutable. https://github.com/kneasle/sapling/blob/4786ca439d7ccc27297e9810425f452aaa97c20b/src/editor/state.rs#L37 How can we use...

How can I add `:` as valid key? I couldn't find a variant inside `Key` for colon.

I tried to add `mut` in side the trait defintion. And it doens't compile. Surprised me

Learned something new, I feel great.

> Would it cause much chaos if I were to change the type signatures for `State::transition`? No, go ahead. I haven't done much.

https://github.com/kneasle/sapling/blob/b5ec298c38552244d0ba61152febb3737885244e/src/editor/dag.rs#L412-L415 I'm working on this one, and I'm not sure why do you think it is not feasible ? https://github.com/kneasle/sapling/blob/b5ec298c38552244d0ba61152febb3737885244e/src/ast/test_json.rs#L48 Was there a reason that you put an immutable array...

> The thing that made me say this might be hard is that just fixing it for JSON objects is not really enough - I'd like to actually fix the...

Actually I'm close to get a master degree in math. I learned some algorithm, and data structure from math department, but I have almost forgotten all of them. I definitely...

>But I think that was just the person who wrote the exam being overoptimistic about how good the students were. Profs always have unrealistic high expectation on students

> Absolutely laughing! This wasn't the worst module, actually - we had one exam where one of the examiner's reports said something along the lines of 'even compared to other...