Dongkyu Kim comments

Results 8 comments of


                                            Dongkyu Kim

Share sheet button doesn't work

Could you provide more details about your environments? I'll appreciate it if you check this issue still happens on the latest version.

preferredControlAccentColor does not support dark mode in Asset Catalog colors

Hi Sebastian, Thank you for reporting this issue! It will be fixed in the next release. I'll keep you informed when a new version has been released :)

Upgrading @v1.2 -> @v2 can no longer specify short sha in ref

> Notice that the short ref is being quoted in the command. I don't know if that matters or not, but it's definitely failing. Switching back to `@v1` works. @jsumners...

Unexpectedly found nil while unwrapping an Optional value

This issue has been fixed in [v2.4.1](https://github.com/stleamist/BetterSafariView/releases/tag/v2.4.1), as a result of #22. Thank you for your contribution and waiting :)

Fixes Unexpectedly Found Nil When Unwrapping Optional in WebAuthenticationPresenter

Great! I really appreciate your work on fixing this issue! This improvement will be available in v2.4.1 shortly :)

Fixes Unexpectedly Found Nil When Unwrapping Optional in WebAuthenticationPresenter

This issue has been fixed in [v2.4.1](https://github.com/stleamist/BetterSafariView/releases/tag/v2.4.1), as a result of #22. Thank you for your contribution and waiting :)

Add `isIncludedInPinLayoutSizeCalculation` property to `Layoutable`

Hi @lucdion, I've made a proposal to exclude subviews from the size calculation without removing them. I'd appreciate it if you could review it! :)

Add `isIncludedInPinLayoutSizeCalculation` property to `Layoutable`

I'll let you know when the documentation is complete!