Steven Sloan
Steven Sloan
Reading the docs (https://api.slack.com/docs/formatting#parsing_modes) and testing, Slack will already auto-detect bare urls. Are you running into cases where that isn't happening? Modified integration test for example: ``` ruby notifier =...
oh ic, that makes sense. I think it'd be worth adding, but only run if you pass a flag to the `::format` -- lets say `autolink` just to match redcarpet....
Sorry @technicalpickles, I was hopping to get this out tonight. I realized that adding the link formatter options should really be a 2.0 feature, and include things like setting escaping...
@siegy22 sorry about that, you should have an invite to be a maintainer -- I \*thought\* I'd done that when I split this off to an org instead of my...
You've dug in a bit more so I'd trust your judgement, but seems like [working with a match object](https://github.com/pvdb/faraday/commit/ad94eab5063a7bd2db4f71e1e39067d68d159cd0) instead of `Regexp.last_match` would be a good fix? (I think I...
Yeah, I guess it could -- I was thinking though since we're setting [linked asset paths here](https://github.com/middleman/middleman-sprockets/blob/master/lib/middleman-sprockets/extension.rb#L117-L119) that allowing users to give a proc for that would be easier to...
It looks like at some point during the middleman 4.0 development, the method middleman-sprockets is using as a v4 check changed names [via changelog](https://github.com/middleman/middleman/blob/09f3be9aba1ee07d5afcf8601e368f1e8fa8c524/CHANGELOG.md#400beta1): > rename app.add_to_config_context to Extension.expose_to_config for...
IIRC adding paths to sprockets changed a little bit, the [upgrade guide](https://github.com/middleman/middleman-sprockets/blob/master/docs/upgrade-3-to-4.md#importing-assets) may help. If you can share your `config.rb` and some of your asset paths I'm happy to help...
One thing I see is that there doesn't appear to be a `preloadjs-NEXT.combined.js` file in your `vendor/PreloadJS/lib` directory. Looks like they changed that once they released [`1.0.1`](https://github.com/CreateJS/PreloadJS/commit/6fa5513a8e97fba1514f3f36bfab1f4c83de6718#diff-e8acc63b1e238f3255c900eed37254b8), I think if...
Happy to take any PRs, but Sprockets 4 is still in beta