Steven Weerdenburg

Distribute optimized framework builds with easy debugging

7

As noted in https://github.com/nunit/nunit/pull/4035#issuecomment-1200160651 In https://github.com/nunit/nunit/pull/3464 we stopped using sourcelink in favour of distributing a debug build of the framework with embedded symbols + source, however it seems this can...

Make `Numerics` class internal

4

Most of NUnit's numeric-related work (comparisons, differences, equality) is exposed via constraints or the classic assertion model, but the work itself is done by a helper class: [Numerics](https://github.com/nunit/nunit/blob/master/src/NUnitFramework/framework/Constraints/Numerics.cs). This helper...

Create generic classes for ExactTypeConstraint and ExceptionTypeConstraint

2

ExactTypeConstraint and ExceptionTypeConstraint both check if variable is an exact instance of a type. The constraints each have a generic `ApplyTo(TActual actual)` function but the `expectedType` it compared to is...

Port caching of method discovery to main

7

Fixes #4053 Migrates: - #4034 - #4104 Relates to: - #4096 - #4107

Store Timeout interval as a `TimeSpan` instead of an `int`

4

Something I noticed today is that we store timeout intervals as an `int`. Newer .NET framework guidelines suggest instead using `TimeSpan` to disambiguate the represented time interval (seconds vs milliseconds)....

Cache method discovery by migrating PR 4034 to main

2

PR #4034 added caching of method lookups. It was merged to 3.13, we should consider also syncing it to main/v4

Consider optimizing `StreamsComparer` for happy path

5

StreamsComparer currently compares the bytes of two streams and reports on the index of the first difference. It does this by reading the streams 4096 bytes at a time into...

Improve string comparison consistency with regards to cultures

18

The codebase currently uses a mix of different approaches to do string comparisons: - StartWith / EndWith use culture aware no matter what - Equality / Uniqueness use culture aware...

Enforce consistent code styles between framework and other projects like the analyzers

3

Something which has come up in PRs a few times recently is that the framework has a more lax editorconfig ruleset than the analyzers project (and potentially others??). It specifically...

Cache comparer when comparing two IEnumerable<T>

2

The arrays and enumerables comparer currently will iterate over and evaluate each item in an array independently and determine the comparer for each. I imagine most usages of this API...