Steven-Jaro

Results 16 comments of Steven-Jaro

How hard would it be to add a tension dot? What I mean by this is that the curve looks fine but what if I want to change the shape...

> Works well but i get these occasional crackles and the audio peaks. ![image](https://private-user-images.githubusercontent.com/62200778/447244685-1a2839ad-e4bf-4e2a-b697-f487631d03b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDgwOTQwOTIsIm5iZiI6MTc0ODA5Mzc5MiwicGF0aCI6Ii82MjIwMDc3OC80NDcyNDQ2ODUtMWEyODM5YWQtZTRiZi00ZTJhLWI2OTctZjQ4NzYzMWQwM2IwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTI0VDEzMzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZmYmRkOTM0MzYwNWQyMGVjY2Y4NzcxYWY5MDQ2OGViNjFmMjZlNGZkY2VmOTg4YjJjOWVmY2RkY2QzOTU0YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.XKqmJEvjbOlpPkD4kZpdB2eMK6qIPscSHwkaBPzyG30) > > edit: Audacity doesn't have this issue Hey, thanks for the feedback.

I changed the approach as it was pretty unstable. Please feel free to test the code and review it. My new approach also is supposed to fix the random segfaults...

> ![image](https://private-user-images.githubusercontent.com/62200778/447354257-b675c20c-0dc0-4a4a-ae87-e4c81722607e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDgxOTU5MTEsIm5iZiI6MTc0ODE5NTYxMSwicGF0aCI6Ii82MjIwMDc3OC80NDczNTQyNTctYjY3NWMyMGMtMGRjMC00YTRhLWFlODctZTRjODE3MjI2MDdlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTI1VDE3NTMzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0YTZhOTEzNGU2NTE3MWU3OGE2NmY2MDQ4ODNjMDg1YjBjN2Y2NTEwNTgxZTgyZGMwNWI4ZmMyZjZiZjliMzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.m0LyzTYl9dQ7Zn-RysizuvCxsBJnMV4LU9Xmcoe313g) You fixed it, great job! Still seems run smoothly too, haven't had any crashes or bugs Thank you for the feedback and testing.

My most recent push has the intent to remove all the allocation I could think of to get more real time safety. I think there is still some points with...

> Help me understand this code... > > Before this PR, were we using a single buffer `m_inputBuffer[m_inputBufferWrite]` for recording audio which would just be scaled up 2x every time...

I solved the problems with the resize and reserve. Now it is supposed to be completely real time safe.

All changes requested will be applied. But I just have that doubt with the and statement.