Steve Matney

Results 27 comments of Steve Matney

@Westbrook we're using `dom-testing-library` to test some Web Components, and would love to see our approach simplified by a package like the one you mentioned potentially creating. Do you have...

This is likely to have been resolved with #80, which is currently on the `develop` branch.

This is likely to have been resolved with #80, which is currently on the `develop` branch.

Thanks for all your work on this @fleischie! I'd love to help maintain it, but I've never built or maintained a Vim package. Just made some basic PRs to this...

I was also seeing this issue while working on #80, which has been merged to the `develop` branch. I think I fixed it.

It may be a _bigger_ concern that exports that are actually used are getting marked as unused, but I'm not as familiar with how webpack decides what is used and...

I understand that I could remove the Promises to make everything work, and not use `externalsType: ‘promise’`, but the repo is written with the explicit intention to show the bug....

> ...You can't use Promise.resolve in externals when you have externalsType: "promise"... I don't understand this. It's definitely working as expected, for the most part. In fact, the example repo...

I understand what you're saying, but in the case of my example repo, none of the parameters passed to `Promise.resolve` are themselves promises. For example, in the case of `Promise.resolve(React)`,...

> You want inject promised external deps in non promised code... This is what using `externalsType: promise` already does. My original modules may or may not be written with promises,...