sterrettm2
sterrettm2
I've updated the version of highway, so the performance bug on AArch64 should be resolved. I've also done everything suggested in the review; the only thing is, it would be...
I've rebased it, and those weird Circle CI failures seem to have vanished.
> May I know if the benchmark was collected with single core or multi-core? Can you share the result for both configurations? This was on a Skylake machine (7900x), set...
> The perf numbers LGTM. Seems CI failures are related. Could you please fix them first? I've spent a while looking at the test failure, and I think the test...
I've made the changes suggested by Raghuveer, and I changed the previous fix for the test. Now it passes a comparator function to determine how to check for equality, does...
I've made those modifications, except for moving the input checker into the default comparator. I think that should be ran regardless of which comparator is used, so I left it...
Pinging @jgong5, I think my newest commit should fix the suggestions you had, could you take a look at it?
`equal_sort_checker` does not have special logic for checking the inputs. I assume you are referring to this code: ``` self.assertEqual( ref_inputs[0][actual.indices], ref_inputs[0][correct.indices], atol=atol, rtol=rtol, equal_nan=True, exact_dtype=exact_dtype, ) ``` If that's...
I've got the CLA figured out, and rebased on the current branch. I think it should all be good, once the tests have been run again
Hopefully that should have resolved all of the issues with the CI, could you rerun it?