Ste Prescott

Results 13 comments of Ste Prescott

I've taken some time to look into updating Peril to use to latest [10.1.0](https://github.com/danger/danger-js/releases/tag/10.1.0) release to no success. I've been using https://github.com/danger/danger-js/pull/983 as a reference guide to see what changes...

@gr2m Any advice from you as you did the danger update.

Sorry for the late reply. I'm not a big fan of the new GitHub notifications UI so I miss these a lot. I have a [branch](https://github.com/danger/peril/compare/update/danger) `update/danger`.

Yer I’m new to TypeScript myself. Thanks for what you have done this far.

@luin Sorry if this is not the right approach but do I need to tag you or someone else to start the review process? I wasn't sure after reading the...

@luin just bumping this in hope it can be reviewed. If you need anything further from me please do let me know.

Just to wade in. With the changes made in #452 it resulted in my `TEST_HOST` not being set correctly. I'll dig into this further tomorrow but the setup that causes...

Example project seen at https://github.com/user-attachments/files/17016358/Example.zip can be used to replicate this. By switching between 15.4 and 16 can replicate this.

Sure. I'll look into that tomorrow morning. Thanks for pointing me in the right direction.

I'm not sure I am reading the data at the right location as the raw data, before decoding, still has no items. I'm in [JSONRPCSession.swift](https://github.com/ChimeHQ/JSONRPC/blob/ef61a695bafa0e07080dadac65a0c59b37880548/Sources/JSONRPC/JSONRPCSession.swift#L133).