stephenworsley

Results 82 comments of stephenworsley

This is still of interest and we believe there is enough demand to justify doing some work on this.

> Peloton discussion - this passes for meshes that are contiguous, but fails to recognise some meshes that aren't contiguous. I've had another look at my comments for this and...

While the problem is similar, I don't think it is due to a use of `array_equal()` in this case. It seems as though the problem here is due to comparisons...

Due to changes in Python 3.10, the approach I took to fix this no longer seems viable. Until we come up with a better solution, #4701 has been reverted so...

@QuLogic here's an example. Before the fix: ![missing_poly](https://user-images.githubusercontent.com/49274989/72065697-bcca8300-32d6-11ea-9941-80fa9c80e79d.png) setting alpha to 0.5, we can see that there is a polygon which is being plot but overwritten. ![missing_poly_alpha](https://user-images.githubusercontent.com/49274989/72065934-467a5080-32d7-11ea-879f-f8462f48f0bd.png) After the fix:...

@QuLogic I've tried the above piece of code and it doesn't seem to fix the plot. I believe the path in the test is a simplification. I may not have...

@QuLogic The exact values of path_verts are `[[193.75, -14.166664123535156], [193.75, -14.166664123535158], [193.75, -14.166664123535156]]` so a more accurate simplification for the tests would be `[[1, 1], [1, 2], [1, 1]]`

The following code, placed just before `verts_same_as_first` is created, seems to work. ``` if len(path_verts) == 3: path_verts[1:, :] = path_verts[0, :] ``` Would this also be a preferable solution?

I can confirm that #1456 also fixes the plot, looks promising.

I suspect this may be fixed by https://github.com/OSGeo/PROJ/pull/3082.