Stephen Quan

Results 34 comments of Stephen Quan

These are some of the designs we considered for our project 1. Allow the user to supply their string resource: .UseLocalizationResourceManager(Type stringResource) .UseLocalizationResourceManager() => UseLocalizationResourceManager(typeof(T)) Then we append the resource...

As per @screaming-snake-case by changing it your SVG to use shape fills is the key. This answer uses defines the shape using a shape defined by semi circle arcs. The...

Workaround, insert into the codepoints dictionary object reservation for the affected codepoints, e.g. ```js module.exports = { name: 'my-icons', fontHeight: 500, normalize: true, inputDir: './icons', outputDir: './dist', fontTypes: ['ttf'], assetTypes:...

Hi @brminnick since your review, I have: - attempted to update the fork with the base branch - corrected the unit test issues you raised - added more unit test...

Thanks @pictos, I have reviewed the CS8063 possible null reference return issues and have resolved it by making nullability updates to both the MathExpression.shared.cs and MathExpressionConverter.shared.cs. The nullability updates also...

@pictos @bijington I have pushed updates to the fork address both the C# property name pattern and logging invalid math expressions with TraceWarning. Because we're no longer raising invalid math...

@pictos @brminnick as requested, I have removed the Null Forgiving Operator from the MultiMathExpressionConverter. I have corrected the null checks in the MultiMathExpressionConverter and that resulted in a necessary minor...

Hi all, we are using snapshot copies of these classes in our projects. I am eager to help out and remove any blockers on this PR.