Stephen Hines

Results 11 comments of Stephen Hines

TSan was never released in the NDK, so this is more of a feature request. @yabinc did have it working in the platform, but there are other components that would...

You can't really use `aosp: external/compiler-rt/lib/tsan` to build a tsan runtime, as `external/compiler-rt` in AOSP is actually the compiler-rt used for RenderScript. It is also several **years** out of date....

No, we have no timeline for when LSan will be available in Android.

It just isn't a priority at this time. We don't have the ability to take on every project that could be helpful.

This is a feature request, and official support requires additional testing if we are going to advertise it in the NDK. I think that would be the biggest remaining blocker...

A bit of searching pointed me to https://github.com/android/renderscript-intrinsics-replacement-toolkit/issues/6, which might be adapted to work for you as well. I think the problem is that these other YUV types are newer...

@eugenis I see that https://github.com/zchrissirhcz/min-repros/blob/master/test_asan_for_intrinsics/build/android-arm64-build.sh says it is running on r23b. I see you said that the bug isn't present on NDK r23, but this seems odd. Did you mean...

> Why you decided to choose WASM instead of LLVM IR? Why this additional translation step is necessary (Native code -> LLVM IR -> WASM -> LLVM IR -> Binary),...

https://github.com/llvm/llvm-project/blob/main/compiler-rt/CMakeLists.txt#L285-L287 makes it look like that the sanitizer runtimes get built with `-fomit-frame-pointer` in this case. @enh-google you're thinking about the Android platform build which specifies this flag explicitly for...

Yes, frame pointers are on by default for 32-bit ARM/Thumb and 64-bit AArch64 Android [[Code](https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L520-L559)]. Surprisingly, the driver default for x86-related targets depends on optimization level [[Code](https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L566-L568)]. Ugh.