Stephen Bach
Stephen Bach
Hi, Great question! And thanks for trying this out. It doesn't support categorical classes right now, but it's just because we wrote the structure learning code before adding categoricals to...
Hey @Muennighoff ! Unless I'm misremembering, this is only changed on the `eval-hackathon` branch. This was a feature requested by the eval team, and maybe @cjlovering or @jordiclive can point...
Thanks! I had enough spanish in school that these I can sort of understand, but the same feedback as #761 seems to apply here as well. Also it looks like...
Can you make this PR target the eval-hackathon branch? Thanks!
Sorry, I took so long to look at this that it's fallen out of date. Can you resolve the conflicts and I can take another look?
Whoops, I DMed @KhalidAlt. Please don’t merge yet. There’s some code duplication in templates.py that needs to be removed.
Also do we like/need the allow_unicode=True argument? I’m not sure exactly what it does. Should we use it to regenerate all the .yaml at once to avoid unexpected diffs down...
There's a .app.py.swp in the changes.
Oh my bad, I see now that you were removing it, not adding it. Merging now. Thanks for your patience and hard work on this!
For the record, show_new_templates fails because the dataset is too big to run on GitHub and check_templates fails because of the issue that #832 addresses.