Stephen Lineker-Miller

Results 15 comments of Stephen Lineker-Miller

`npm link` will do link between the bin and the current directly. e.g making solcjs work as expected. I think this is is the perferred way of handling local packages...

> But `npm link` tries to put the link into global dirs. If I'm not installing the package globally (e.g. I have multiple copies and it's just one of them)...

This was raised here #599 about flattening the directory and build entirely, but generally building into a dist folder is preferred and easier to manage.

> Hey, @stephensli thank you very much for this amazing work! :) I took a look at your PR and made some comments. Some comments require discussion with the rest...

ping 🏓 https://github.com/ethereum/solc-js/pull/442

I'm happy to be the person who starts actioning on this. Including what @MicahZoltu has just mentioned above.

That is all fine @cameel, no worries. I will start staging it, e.g setup the infrastructure (building), renaming etc in one pull request and then allow building on that.

I have gone and started up the first pull request to start the base work for moving into the Typescript space, its #566 and its all open to conversation.

#567 Pull request has just been open to start the process of moving to Eslint.

HI @GrandSchtroumpf, exposed types have been added here: https://github.com/ethereum/solc-js/blob/540a9643cd7974e329287ebf8d4c2c70d744c11d/common/types.ts pending a existing PR has to go in first. These are currently in review.