Stefano Fiorentino

Results 19 comments of Stefano Fiorentino

ciao @darktohka, [this](https://github.com/skypjack/uvw/pull/266/commits/f571fc3cfd596e4bdeac609938d923ef2f79464c#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR121) line is not totally convincing me. Distribution packages does usually not provide the static version of libs. Have you a custom environment? (aka did you manually install...

> Yes, I've compiled and installed libuv as a static library. pkgconfig can detect the static variant as well. So as it is a custom setup, and not the one...

I'm still not fully convinced by the introduction of a new variable only for this special case. But I've to admit I need to dig deeper into this.

@skypjack do you need any help to get the pipeline back to green too?

@skypjack it fails tests on my env (WSL2 ubuntu-20.04): ``` [ctest] ../test/uvw/loop.cpp:86: Failure [ctest] Expected equality of these values: [ctest] count [ctest] Which is: 11 [ctest] 12u [ctest] Which is:...

Some (little) investigations yield this: - the failing test is Loop.walk - by enabling USE_ASAN the "Loop" tests pass, but "616 byte(s) leaked in 5 allocation(s)". I'm wondering, why we...

@skypjack launching them 1-by-1 with --gtest_filter only `Loop.Close` causes the leak.

Probably the uv_loop_close returns UV_EBUSY. I've to stop investigations for a while.