stefan-egli

Results 33 comments of stefan-egli

one concern that just came to mind with this: obviously this would increase the number of queries executed - and that scales with the number of clusterNodeIds in use...

Maybe to compensate for that, do less frequent RGC, currently it runs every 5sec by default - changing that to every 1min might not have too much of an impact

* added logic to avoid calling `deleteMany` for idle clusterNodeIds - plus tests for this * added a test for number of `deleteMany` calls for the above and some of...

@mreutegg, as I have modified this PR from your earlier review would appreciate a second (final?) review, thx!

@reschke , now created OAK-10730 for logging the MongoException - it's not entirely clear at what level we should log though - I would suggest to not go log.error right...

It looks like you have accidentally deleted files from `oak-shaded-guava` (which also breaks the build in this branch). Also suspecting some other changes are required to get it compile -...

@Joscorbe , @rishabhdaim , this is more FYI as we should first merge OAK-10688 (and then I'd redo this PR from DetailedGC directly)

Replaced by https://github.com/apache/jackrabbit-oak/pull/1377

@jsedding do you think we should incorporate this PR?

actually, there are compilation errors: ``` [INFO] ------------------------------------------------------------- Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/jackrabbit-oak/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:[367,11] setStatisticsProvider(org.apache.jackrabbit.oak.stats.StatisticsProvider) is not public in org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector; cannot be accessed from outside package Error: /home/runner/work/jackrabbit-oak/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:[538,11]...