Christopher Peters

I found myself wanting to update a table in response to a form submission. This is how I did it, if it's useful to anyone.

Statwonk's suggested edits

2

I'll use this PR to hold suggested edits. I'm really enjoying the work so far @ASKurz, I can tell you've put a lot of hard work into it!

Test of ids fails for ES 2.0.0

2

https://travis-ci.org/ropensci/elasticdsl/jobs/116706796. I don't get the error locally when using `docker run -p 9200:9200 elastisearch:2.0.0` ``` r > connect(Sys.getenv("ES_IP")) url: http://192.168.99.100 port: 9200 username: NULL password: NULL errors: simple Elasticsearch (ES)...

Prototype of an aggs parser handle.

6

This is more of a proposal than anything and I don't intend for a merge into `master`, at least not withstanding major polishing. Here's my little toy code for playing...

Review dplyr's filter boolean logic implementation.

3

I really like dplyr's `filter(this | that)` (and also `filter(this %or% that)`, it'd be nice to implement that here.

Deconflict exported function names.

2

For example `dplyr::filter` and `elastidsl::filter`, see https://github.com/ropensci/elasticdsl/commit/473cb8a4ae18bd8b697a30bebb4c6b3031652271#commitcomment-16407534 A good solution to this particular example would prevent masking when both libraries are loaded.

Filter examples are currently broken.

2

@sckott do the following examples currently work for you on `master`? Bug hunting ... https://github.com/ropensci/elasticdsl#filters ``` r index("shakespeare") %>% filter() %>% prefix(speaker = "we") %>% exec() %>% n() ``` ```...