Ethan Brown

data_diff objects fail on round trip to Rdata files

1

I found the following behavior surprising: ```r library(daff) example(diff_data) # creates the "dd" patch save(dd, file = "patch_loading.Rdata") load("patch_loading.Rdata") dd ## Error in context_eval(join(src), private$context) : ## Context has been...

Extraneous `tidyverse_conflicts()` for re-exported functions

1

`tidyverse::tidyverse_conflicts()` gives what I think is an extraneous conflict between `dplyr::filter()` and `simpr::filter()`, even though `simpr::filter()` is just a re-export of the generic S3 method of `dplyr::filter()`. ``` r suppressPackageStartupMessages(library(simpr))...

Is the data provided US only? If so, can that be made more clear in the documentation? After spending several hours setting up and figuring out this package I found...

`generate()` doesn't clearly discuss fact that `simpr` already includes futures. Also, `vignette("Optimization")` should be `vignette("optimization")`. HT @FallingPineapples

Accomodate number of simulations within `specify()` for functions that already return multiple simulations

3

If something is already written as a simulation package, the only way to interface `simpr` with that package is to have that package simulate one value at a time, which...

Ignores unnamed arguments: ``` r library(simpr) #> #> Attaching package: 'simpr' #> The following object is masked from 'package:stats': #> #> filter #> The following objects are masked from 'package:base':...

Currently `specify` generates a warning and no output when arguments have differing numbers of rows: ``` r suppressPackageStartupMessages(library(simpr)) sim = specify(pre = ~ rnorm(n1), post = ~ rnorm(n2)) %>% define(n1...

This is confusing for users of other tidiers, such as those provided by `broom.mixed`, and somewhat works against the purpose of having general methods in `generics`.

Showcase article for pkgdown site with example simpr simulations with more reasonable numbers of reps (not a vignette, too slow). Draw from inst/showcase.R and the existing interaction example on the...

`specify()` with a single formula provides a huge variety of mysterious output: ``` r suppressPackageStartupMessages(library(simpr)) specify(y ~ 1 + 2) #> Formula specification for 'x' detected. Assuming 'x' is the...