Egor Starovoitov comments

Results 49 comments of


                                            Egor Starovoitov

It does not send hex numbers 11 and 13

These symbols are used to provide pacing of the data stream in applications with limited performance. Perhaps the library just filters them to avoid any interpretation.

BufRead::read_line() doesn't work when timeout is set to 0

I believe it is necessary to avoid zero timeouts, perhaps it is worth adding a corresponding 'assert' into the '.timeout()'.

Replace PathBuf to AsRef<Path> in the Engine file API

> Yes, because now the compiler does not know which type we want to pass. But this can be easily fixed by removing ".into()".

Replace PathBuf to AsRef<Path> in the Engine file API

> > > > > > > > > Yes, because now the compiler does not know which type we want to pass. But this can be easily fixed by...

Replace PathBuf to AsRef<Path> in the Engine file API

> > I think we can try to add a new type that implements both `AsRef ` and `Into` traits for various types being passed. But isn't there any less...

Why does Engine::eval_file_with_scope use PathBuf instead of Path?

Thanks for the quick response, I hope these changes will come someday. And... Can I contribute to this?

Why does Engine::eval_file_with_scope use PathBuf instead of Path?

I opened the pull request with these changes

Add drain_filter for SlotMap

How is this issue going? Do you need help?

Add drain_filter for SlotMap

I've seen glidesort, great job! I will follow updates and news here and there. What do you think about adding "help wanted" notes on this and other repositories? I am...

Feature Request: Add `into_nodes_edges` to `StableGraph` mirroring `Graph`

Hello! Your proposed solution looks good in my opinion. Could you open a PR with this implementation? I would also suggest naming the new function `into_nodes_edges_iters` so as not to...