Stan Moore comments

Results 457 comments of


                                            Stan Moore

Cuda: Adding implementation to use cudaFuncCachePreferEqual when needed.

@rgayatri23 Any update on this PR? We could really use this in LAMMPS.

Current status of mathematical functions

`sincos`--needed a wrapper for SYCL

Current status of mathematical functions

We don't currently need `sincos`--it was in SNAP for a while but it got removed in the latest version

Minimum Compiler Version Update

I think we need to support `cuda/11.0.3` on Summit since newer CUDA versions are broken with SpectrumMPI CUDA-aware.

Minimum Compiler Version Update

i.e. `cuda/11.1` and above are broken for CUDA-aware MPI on Summit

Minimum Compiler Version Update

Correction, I just tried and`cuda/11.1.1` works for CUDA-aware MPI, but anything higher on Summit, e.g. `cuda/11.3.1` and above are broken. This is a known issue with OLCF, but no idea...

Consider changing the behavior of `Kokkos::is_initialized` and providing `Kokkos::is_finalized`?

Also related: https://github.com/kokkos/kokkos/issues/4126

Consider changing the behavior of `Kokkos::is_initialized` and providing `Kokkos::is_finalized`?

I support this change--I had to add logic in LAMMPS to work around the lack of `Kokkos::is_finalized()`, see https://github.com/lammps/lammps/blob/develop/src/KOKKOS/kokkos.cpp#L337-L353, would be nice to simplify the user code.

Consider changing the behavior of `Kokkos::is_initialized` and providing `Kokkos::is_finalized`?

I like Option 2 as well.

[Feature Request] Use runtime detection for `have_gpu_aware`

@ocaisa sorry for the delay. We do have some runtime detection in `kokkos.cpp`, for example: https://github.com/lammps/lammps/blob/develop/src/KOKKOS/kokkos.cpp#L301-L303 Are you saying we should add `MPIX_Query_cuda_support()` to this part of the code?