Stanislav Halyn
Stanislav Halyn
I will prepare a PR since the fix seems quite straightforward: add a `visited` `WeakSet` to check if we have processed the item already.
@TkDodo yeah, I think it should, because it took me some time to figure out what was the issue with the query, since I didn't know my data wasn't JSON-serializable
@RedYetiDev > Are you sure it's not the server that is being requested? Have you tried to reproduce with another http2 client? Yeah, I'm sure it's not the server that...
I just ran node profiler for the script I provided fetching our internal API, and the results are weird... Here's the summary for http2 ``` [Summary]: ticks total nonlib name...
@mcollina I did some testing today and found some new insights. This does not happen for our internal endpoints with little data, those are processed faster with http2. When fetching...
@puskin94 I just re-run the tests on our internal APIs, and to my surprise the results are the same now. The results for a 25 parallel requests to a heavy...
@puskin94 yeah, you might be right 😄 I just re-run the tests for the `https://nodejs.org/dist/index.json` endpoint on a different machine with two different network configurations: my home network(~600mbps) and mobile...
@puskin94 It's really weird because I still can reproduce the issue on one of our internal API endpoints which is quite JSON-heavy with lots of text (384803 bytes). Here're the...
@puskin94 but why `curl` has the same performance on both http1.1 and http2 and only node suffers from bad performance on http2? I also ran the same test using an...
@mcollina @jasnell maybe you could point where I could look into to try to debug poor performance on node http2 client?