Samuel Štancl

Results 378 comments of Samuel Štancl

And for the rest of us who can't send large sums but have benefited from Ondřej's work in the past... ![Screen Shot 2020-10-08 at 15 07 27](https://user-images.githubusercontent.com/33033094/95462584-fcaebb80-0977-11eb-98e6-186a4db7d9ba.png)

The main issue I see with using a single helper for both is the signature — right now we have `$domain` first, which makes sense. I think we should first...

Can you attempt a separate PR with the implementation that sets the default tenant model? Also, can you expand on the separate middleware? Would `URL::default()` set this for **all** routes...

> Plus, I think we shouldn't set tenant parameters on all routes out of the box by default. Then how would the middleware work? That was my question.

Okay, but I don't see what the middleware does **differently from simply executing `URL::defaults()`** anywhere else? It's not like it will be limited to those routes. Re-read what I asked...

> It will be applied to the routes only implementing this middleware. Why? It will be **applied** to all routes, the only difference is that it's **executed** on a route...

Closing in favor of #925

Wrote a comment regrading the above on Basecamp 👍🏻

Create a message on BC, we'll discuss it there in depth 👍🏻