staffantj

_ReadWriteBarrier() is deprecated in MSVC 2015 (possibly earlier)

2

With the library being rebased on C++11, we should be using std::atomic_thread_fence instead per https://docs.microsoft.com/en-us/cpp/intrinsics/readwritebarrier?view=vs-2015 On the assumption that the fence is only being used to prevent read/write re-ordering, it...

Restrictive number of streams

1

The max problem size defines in PDQ_lib.h are too restrictive (at least for the size of problems I'm running). In particular the MAXSTREAMS parameter at 64 is an issue. In...

We're in C++17, we have [[maybe_unused]], as well as empty-declaration parameters available.

RipTide.cpp defines min/max macros using the naive implementation which is subtly wrong, depending on the arguments passed. We should be using the STL version instead.

This change is fine for now, but it'd be a good idea to make another pass through the code (in a separate changelist/PR) to get rid of these constants sprinkled...

MathThread & Co over-/mis-using volatile variables instead of suitable atomics

1

There are a number of places where the code makes use of volatile variables, where it should be using variants of atomic ones (the comments even indicate that they should...