Su Sun

Results 13 comments of Su Sun

Hi Matt, what's the status of this PR? Could you rebase this to the main branch? I tried rebasing on my own and resolving a bunch of conflicts (mostly related...

Hi @mjohnson541 , I saw that this branch has been rebased onto PR #259 which includes the changes to the new `PythonCall.jl` interface from PR #256 . So to merge...

Hi @mjohnson541. I think we are closing in on merge Electrocat into RMG. The RMG-Py and RMG-database branches are now both ready to deploy. Our plan is to temporarily run...

Hi Matt, I've been trying to have RMG-electrochem to work for the electrocatalytic CO2 reduction reaction. David has done some work on this for his thesis and had this branch:...

Hi Matt, I have several questions regarding the `ArrheniusChargeTransfer` kinetics class. It has an attribute `V0` that seems to always be 0 volt. 1) What is the definition of this...

This PR will temporarily use the corresponding sister PR for RMG-Py for CI. I'm assuming we are in the same situation as electrochemistry where we have to make sure everything...

@mjohnson541 I realized that certain unit tests, such as `aeTest` and `corrTest` require the new reference sets and BAC/AEC values to pass. I temporarily ignored those to pass the CI...

This PR is waiting on https://github.com/ReactionMechanismGenerator/RMG-database/pull/671 . After rebasing it we could merge but will have to ignore the failing CIs. The latest successful CI is [here](https://github.com/ReactionMechanismGenerator/RMG-database/actions/runs/11701310582) and the database...

Hi @LekiaAnonim , thanks for opening this PR. Make sure the title of the PR is concise (by default GitHub uses the full commit message of the latest commit as...

> Not sure how I didn't see that failure when I tested RMS main on RMG-Py before I moved for_rmg to it. Why is our daily scheduled CI on RMG...