Scott Stern comments

Results 13 comments of


                                            Scott Stern

update() doesn't work for component conditional rendering (based on state)

My speculation is that getNodesInternal in ReactWrapper.js isnt calling update on a state change, like Shallow is currently. A code snippet would help.

update() doesn't work for component conditional rendering (based on state)

thanks for the code snippet, per @minznerjosh rec, does wrapper.debug() output null? Ill have some time to look into this this week.

update() doesn't work for component conditional rendering (based on state)

@gilneto8 could you try it with shallow to see if it works? Also, findAttr is using enzymes .find or is this a custom built thing?

update() doesn't work for component conditional rendering (based on state)

thanks for the report, everyone.

update() doesn't work for component conditional rendering (based on state)

@ljharb should this be a bug or an enhancement? Is wrapper.update() for mount "supposed" to propagate the change to children. The docs dont state that it will update the children...

update() doesn't work for component conditional rendering (based on state)

@minznerjosh ill do that and look into the issue as a whole.

update() doesn't work for component conditional rendering (based on state)

From what i can tell its working as expected locally when writing the tests so decided not to push. Thinking the issue might be something else with the way the...

update() doesn't work for component conditional rendering (based on state)

cc @minznerjosh

[Fix] `shallow`: `x.find()` should not change state of `x`

re > I suspect we'll need to add shouldComponentUpdate to all the adapters. If we have the conditional to check if the shouldUpdateComponent is present why would we need to...

[Fix] `shallow`: `x.find()` should not change state of `x`

So sorry, didnt get pinged on my email. Yes I will prioritize this week. I sincerely apologize, a lot of personal things going on right now has been hard to...